Ability to specify usage of the unsafe credentials filestore explicitely#6719
Open
WildRackoon wants to merge 3 commits intodocker:masterfrom
Open
Ability to specify usage of the unsafe credentials filestore explicitely#6719WildRackoon wants to merge 3 commits intodocker:masterfrom
filestore explicitely#6719WildRackoon wants to merge 3 commits intodocker:masterfrom
Conversation
Signed-off-by: Rackoon <32634987+WildRackoon@users.noreply.github.com>
Signed-off-by: Rackoon <32634987+WildRackoon@users.noreply.github.com>
Signed-off-by: Rackoon <32634987+WildRackoon@users.noreply.github.com>
WildRackoon
force-pushed
the
explicit-credential-filestore
branch
from
1e76cc7 to
ebb3d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current default behavior of
docker login( See Documentation) is to select default credentials store based on credential-helpers PATH availability and only falls back to the unsafefilestoreif no other is available.unsafefilestore is to remove credential-helpers from your PATH.credHelpersaccordingly.This meagre MR is only trying to solve this suboptimal situation.
Despite previous efforts to deprecate / strongly discourage its usage, it is still going strong, since there actually are valid usage for basic auth methods. The right step forward would be to allow for no storage at all (As suggested here: #559 (comment))